ARROW-5125: [Python] Round-trip extreme dates on windows#5306
Closed
emkornfield wants to merge 7 commits intoapache:masterfrom
Closed
ARROW-5125: [Python] Round-trip extreme dates on windows#5306emkornfield wants to merge 7 commits intoapache:masterfrom
emkornfield wants to merge 7 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@ursabot build |
emkornfield
commented
Sep 6, 2019
Contributor
Author
There was a problem hiding this comment.
this might not be necessary, if we never expect a datetime object here?
Contributor
Author
There was a problem hiding this comment.
In fact I think this is wrong (we always want truncation, but I'll let the reviewer confirm).
Member
There was a problem hiding this comment.
I think it's probably OK, but we should check whether the milliseconds are 0. I'll pull it down and take a quick look
emkornfield
commented
Sep 6, 2019
cpp/src/arrow/python/util/datetime.h
Outdated
Contributor
Author
There was a problem hiding this comment.
an alternative approach would be to do if (pycheck_DateTime(pydate)) here, not sure if that is preferred.
…verting to date64
wesm
force-pushed
the
python_date_roundtrip
branch
from
3f6d944 to
a2b5a8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, tries to fix: ARROW-4746 by separating out PyDateTime_DATE_GET_* calls that should only be called on datetime objects to the appropriate method.
Note, I don't have a windows box readily available to test on, and couldn't replicate on Mac (per linked python issue on the JIRA I believe this is windows only). So I hope we have appveyor tests that cover this.
If there are instructions for running pypy I can see if this fixes ARROW-4746